Repository navigation
Review copper heap and Coscinodiscus causal graphs (batch 25) - #1361
Conversation
realmarcin
left a comment
There was a problem hiding this comment.
Source-based self-adversarial review at exact head 5f7e0faecd6486addf38d462234f7cb6067d29a4, not independent approval.
Addressed #1356/#1357/#1360; separate metadata followups #1358/#1359 remain open. Two records repaired; ten nodes/ten arrows retained with seven exact renames. No new graph structure or Edison spend.
Preserve real iron/sulfur oxidation, conditional copper extraction, pooled nutrient supplementation and partner-specific growth. Separate DNA/RNA field association from taxon-resolved flux, genus from exact species, BLASTP from DMSP consumption, pooled rescue from individual vitamin donation, and phase-specific model fit from universal absence of higher-order interactions. Chemical feedback remains conditional, not removed merely for being cyclic.
23 initial local commands plus 4 remediation commands completed. The initial full suite had 292 passed and one stale mixed-scope ceiling failure; after verifying the exact two-record delta, only the ceiling/comment changed from 122 to 124 and the full suite passed. The initial failure is preserved. One reference validator exit 1 remains, reporting exactly three primary-verified Results quotes absent from the abstract-only local cache. This gate is NOT passed; broad #596 stays open. No curated snippet was promoted to independent cache content. 293 passed in 187.32s (0:03:07); 3 passed in 1.93s; 46 MATCH and 3 documented abstract-cache MISMATCH snippets; 27 unchanged raw blocks and eight tracked caches byte-preserved.
Two identical full renders and exact parsed description coverage. Actual post-commit just check-docs-current passed and left the tree clean. Four intrinsic source corrections move solely community-credited taxa 1221 -> 1217 while total coverage remains 1499; two records become mixed-scope. Other census bounds, participant checks, connectivity behavior and registries are unchanged.
Decision/adversarial/validation records bind every node/arrow and record/cache hashes. Four complete primary main bodies plus three contextual abstracts read; no figure images, supplementary files or visual OCR equation verification. No new copyrighted full body/PDF. Stacked coverage is 123/460, not completion.
Required CI and protected main queue remain mandatory. Do not merge into a topic parent. Move dependents before deleting merged branches.
Network integrity findingsWarnings only — a member with no interaction yet, or a participant matched by ontology id rather than by name, or one on a community-level interaction that resolves to no member. Reported, but does not fail the build. The full report is attached to the workflow run as an artifact. |
5f7e0fa to
e65a2de
Compare
2eb1818 to
041364c
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Source-based self-adversarial review refreshed at exact head e65a2deffbbcd6aa30fb5548c6866a59d426ee9c after integrating merged website PR #1303 (a937575f88ab11ff74683a8902fe13fd80c96165). Not independent approval.
The website merge conflicted only in the parent generated browser page; it was regenerated from the merged renderer and preserved KB. Each dependent owned commit was then rebased, generated pages refreshed, and actual post-commit just check-docs-current run successfully in every worktree. All branches were pushed atomically with exact leases.
Every non-document blob is verified identical to its previously reviewed version except the nine exact upstream website files. This includes unchanged scientific records, taxa, caches, histories, review ledgers and batch-owned regression code. Non-document manifest SHA-256: 84c753bb910d4bf5070e53bc1f15e9f2da9be165389d1dba27c92f4e443d417d. New whole-tree SHA: 18e0b3c4ab7d222726060fa48750d7c598559688. Whole-tree equality to the previous head is NOT claimed because upstream rendering changed.
The parent integration-focused tests passed. The final combined stack suite, including all batch regressions, site/link tests, corpus/network checks, reference-validator canaries and publication-rights tests, reports: 302 passed in 223.43s (0:03:43). All twelve worktrees passed actual docs-current. Batch-specific scientific/access limitations remain as recorded; batch25 still explicitly retains three primary-verified Results quotes absent from its abstract-only cache, not a passed reference gate.
The decision, adversarial-review and validation files remain historical source-review provenance. Required CI must pass at this new head and the protected main queue remains mandatory. Do not merge a child into a topic parent; delete merged branches only after their dependents move.
041364c to
ea372c7
Compare
e65a2de to
37d3d54
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Self-adversarial review refreshed at exact head 37d3d54646896b375fd245b07cfaddb1c43a87a9
after protected main merge of #1307. This is not independent approval.
The entire tree remains identical to the preceding reviewed tree 18e0b3c4ab7d222726060fa48750d7c598559688.
The batch-owned binary patch is byte-identical
(SHA-256 a0ab02f2bcd74031f646bac36fb73be3ad326f205542d94a0109ac0c7ca7c127); only ancestry changed.
Scientific records, caches, source-review output, histories, regression tests, and generated pages
are unchanged. Historical validation results and recorded source/access limitations therefore
remain applicable, but required CI must pass at this new head. No new source review or local test
rerun is claimed by this ancestry-only update.
The protected main queue remains mandatory. Keep dependents on their reviewed parent until that
parent is confirmed merged; move dependents before deleting merged branches.
ea372c7 to
9615b42
Compare
37d3d54 to
5c65f1f
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Self-adversarial review refreshed at exact head 5c65f1f504ff86a343cbb029eb261fd3f97aae4e
after protected main merge of #1312. This is not independent approval.
The entire tree remains identical to the preceding reviewed tree 18e0b3c4ab7d222726060fa48750d7c598559688.
The batch-owned binary patch is byte-identical
(SHA-256 a0ab02f2bcd74031f646bac36fb73be3ad326f205542d94a0109ac0c7ca7c127); only ancestry changed.
Scientific records, caches, source-review output, histories, regression tests, and generated pages
are unchanged. Historical validation results and recorded source/access limitations therefore
remain applicable, but required CI must pass at this new head. No new source review or local test
rerun is claimed by this ancestry-only update.
The protected main queue remains mandatory. Keep dependents on their reviewed parent until that
parent is confirmed merged; move dependents before deleting merged branches.
9615b42 to
9b5e033
Compare
5c65f1f to
8f24d54
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Self-adversarial review refreshed at exact head 8f24d545e60a78687b55f320b14fcb8cf92c8528
after protected main merge of #1315. This is not independent approval.
The entire tree remains identical to the preceding reviewed tree 18e0b3c4ab7d222726060fa48750d7c598559688.
The batch-owned binary patch is byte-identical
(SHA-256 a0ab02f2bcd74031f646bac36fb73be3ad326f205542d94a0109ac0c7ca7c127); only ancestry changed.
Scientific records, caches, source-review output, histories, regression tests, and generated pages
are unchanged. Historical validation results and recorded source/access limitations therefore
remain applicable, but required CI must pass at this new head. No new source review or local test
rerun is claimed by this ancestry-only update.
The protected main queue remains mandatory. Keep dependents on their reviewed parent until that
parent is confirmed merged; move dependents before deleting merged branches.
9b5e033 to
c387b8e
Compare
8f24d54 to
090349e
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Self-adversarial review refreshed at exact head 090349e648f5c663eaffb59a08a4d8d88cf4a38a
after protected main merge of #1318. This is not independent approval.
The entire tree remains identical to the preceding reviewed tree 18e0b3c4ab7d222726060fa48750d7c598559688.
The batch-owned binary patch is byte-identical
(SHA-256 a0ab02f2bcd74031f646bac36fb73be3ad326f205542d94a0109ac0c7ca7c127); only ancestry changed.
Scientific records, caches, source-review output, histories, regression tests, and generated pages
are unchanged. Historical validation results and recorded source/access limitations therefore
remain applicable, but required CI must pass at this new head. No new source review or local test
rerun is claimed by this ancestry-only update.
The protected main queue remains mandatory. Keep dependents on their reviewed parent until that
parent is confirmed merged; move dependents before deleting merged branches.
c387b8e to
d4689ca
Compare
090349e to
b3be2ec
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Self-adversarial review refreshed at exact head b3be2ec110e46f1b568d4f40f981edc36ff879d4
after protected main merge of #1323. This is not independent approval.
The entire tree remains identical to the preceding reviewed tree 18e0b3c4ab7d222726060fa48750d7c598559688.
The batch-owned binary patch is byte-identical
(SHA-256 a0ab02f2bcd74031f646bac36fb73be3ad326f205542d94a0109ac0c7ca7c127); only ancestry changed.
Scientific records, caches, source-review output, histories, regression tests, and generated pages
are unchanged. Historical validation results and recorded source/access limitations therefore
remain applicable, but required CI must pass at this new head. No new source review or local test
rerun is claimed by this ancestry-only update.
The protected main queue remains mandatory. Keep dependents on their reviewed parent until that
parent is confirmed merged; move dependents before deleting merged branches.
b3be2ec to
f202262
Compare
realmarcin
left a comment
There was a problem hiding this comment.
Self-adversarial review refreshed at exact head f202262e7436a174cce150b69017e0a81876f124
after protected main merge of #1328. This is not independent approval.
The entire tree remains identical to the preceding reviewed tree 18e0b3c4ab7d222726060fa48750d7c598559688.
The batch-owned binary patch is byte-identical
(SHA-256 a0ab02f2bcd74031f646bac36fb73be3ad326f205542d94a0109ac0c7ca7c127); only ancestry changed.
Scientific records, caches, source-review output, histories, regression tests, and generated pages
are unchanged. Historical validation results and recorded source/access limitations therefore
remain applicable, but required CI must pass at this new head. No new source review or local test
rerun is claimed by this ancestry-only update.
The protected main queue remains mandatory. Keep dependents on their reviewed parent until that
parent is confirmed merged; move dependents before deleting merged branches.
a46eae1 to
f37bc90
Compare
Summary
Closes #1356. Closes #1357. Closes #1360. Separate metadata followups #1358/#1359 remain open.
Validation
Review Limits
Source-based self-adversarial review, not independent approval. Four complete primary main bodies and three contextual abstracts read. No figure images or supplementary files inspected; OCR equations not visually verified. No new full copyrighted body or PDF added. Unrelated metadata preserved, not certified.
Stacked on batch24 PR #1355. Do not merge into a topic parent or bypass checks. After protected parent merges, restack the owned commit, retarget to main, refresh exact-head review and use the protected queue. Delete merged branches only after dependents move.